Page 9 of 12

Re: Song Fight! Jukebox

Posted: Sun Jun 16, 2013 8:43 pm
by fluffy
Lunkhead wrote:That is due to the super long optional challenge. My layout at the moment is a fixed vertical size. I don't have a scrolling div set up for the optional challenge to handle it when it's extra long. It pushes content down to the point where it overflows past the bottom of the layout. I have been wanting to come up with a better layout/design but haven't had time. I should have more time to work on it soon though.
You could try adding a CSS rule like:

Code: Select all

#fightArtistInfo { overflow-y: scroll; }
although it looksl ike the widget clickable things still overlap it in that case due to the absolute positioning. Something to limit the height of #fightArtistInfo to keep the widgets from overlapping it would be good too. Outting the sidebar content into another div inside, making THAT div overflow:scroll, and limiting its height through some means would probably work.

I did something workable by wrapping that content in another div id="bramble" (still a child to #fightArtistInfo) and adding this CSS rule:

Code: Select all

#bramble { position: relative; height: 600px; overflow-y: scroll;  }

Re: Song Fight! Jukebox

Posted: Sun Jun 16, 2013 9:03 pm
by Lunkhead
Thanks fluffy. I'll probably just add in your change for a quick fix.

I've been trying not to use overflow:scroll because of how iOS devices provide no visual cue that areas like that are scrollable. The song list uses a JavaScript scrollbar because of that. Even that is pretty unusable though because my layout is not tiny mobile screen friendly at this point. Coming up with something that works better on a phone is another reason why I want to redesign things. Although, playing music on the Web on a phone seems kind of crappy because from what I can tell the music stops if the phone screen turns off. So I'm kind of torn between putting effort into a responsive Web design that's a single page app, or working on a native Android app.

Re: Song Fight! Jukebox

Posted: Sun Jun 16, 2013 9:07 pm
by fluffy
There's always doing responsive web design. media-query CSS is pretty easy to write. I use it on my comic site to make it more or less mobile-friendly.

Re: Song Fight! Jukebox

Posted: Mon Jun 17, 2013 9:40 am
by Lunkhead
Yeah. Like I said though, I only have so much time and I think maybe I'd be better off working on an Android app instead. It seems like when it comes to playing music native apps still have an edge.

Anyway, I wound up changing the left column stuff on the homepage, moved next fight and last fight to the top, changed giant "Welcome!" to small "About", and moved the keyboard shortcuts into a popup. That should make some room for the occasional long challenge and/or fightmaster summary.

(I also fixed the cover art lightbox stuff that broke when I upgrade to Bootstrap 2.)

Re: Song Fight! Jukebox

Posted: Mon Jun 17, 2013 11:13 am
by fluffy
When you do write an Android app, remember to use the ridiculously-overlooked fragments API so that you can do a responsive layout for the three people on the planet who have Android tablets. :)

Re: Song Fight! Jukebox

Posted: Tue Jun 18, 2013 1:29 am
by jast
fluffy wrote:so that you can do a responsive layout for the three people on the planet who have Android tablets. :)
Oh hi!

Re: Song Fight! Jukebox

Posted: Sun Aug 25, 2013 9:28 pm
by Lunkhead
Did somebody say "responsive layout"?!?!?!?! I am very pleased to say that it took a lot less work than I thought it would to get a much better responsive tweak to the jukebox than I thought I would get from the effort. After a few hours of hacking this weekend, if you now check out the jukebox on your phone or tablet's Web browser you should see that the site adjusts its layout to hopefully be more useful on your (puny) smaller screens. It also adjusts up to be slightly bigger than it used to get, too, if you have a really large screen (like I know I have). If anybody has any feedback about this change, I'd love to hear it.

Re: Song Fight! Jukebox

Posted: Wed Aug 28, 2013 11:23 am
by Lunkhead
Since I think people don't know or remember, just thought I would mention again that you can have the Jukebox automatically email you the new titles (with the deadline adjusted for your local timezone for those not in Pacific time). Sign up (which is really simple using your Twitter or Facebook account, and I guarantee the Jukebox will not muck with your account or friends or anything) and in your user settings check the box for "New Title Email".

Re: Song Fight! Jukebox

Posted: Wed Aug 28, 2013 10:37 pm
by Lunkhead
OK, I think I eradicated the last few things that were looking really bad on a phone now. I removed the inner scrollbar for the song list, and changed its layout so that it can handle narrow screens and long artist names and fight titles with more aplomb. It even handles "Rockopolousaninjananophone Eternal - The Vishnu Cycle" and "Nympho Leprechauns with RU4REEL feat. Novox and Carol Cleveland Sings"...

If you've got an iOS device, you can make a home screen bookmark for the site with the middle button at the bottom of your mobile Safari screen. On Android you can have to bookmark the site then go into your bookmarks and long press on the bookmark and then you can save it to your home screen.

Re: Song Fight! Jukebox

Posted: Tue Nov 05, 2013 10:11 pm
by Lunkhead
I just pushed a bunch of new code, the primary focus of which is to allow for user created playlists of songs from the archive, along with a bunch of minor bug fixes.

http://sfjukebox.org/playlists/4

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 8:56 am
by Lunkhead
Wow, and within a few hours there are >100 spam playlists. >:( WTF?

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 9:00 am
by ken
What do spambots listen to?

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 9:28 am
by Lunkhead
I didn't put in a requirement to add songs to a playlist, oops. So they created a bunch of empty playlists. I'm going to disable the feature for now. Then when I have time I'm going to put in a two song minimum. I don't think that will stop them but it will at least create a good source of random two song playlists. :/

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 3:57 pm
by fluffy
Just tried logging in via Twitter, and got this ultra-helpful message:
Error!
Unfortunately something has gone wrong. Sorry!

The error message was:
Tried disconnecting and reconnecting my Twitter account, same thing happened.

And of course I also can't save a playlist since it's disabled for spammer stupidity reasons. Thanks, spammers. (Thammers.)

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 5:56 pm
by Caravan Ray
fluffy wrote:Just tried logging in via Twitter, and got this ultra-helpful message:
Error!
Unfortunately something has gone wrong. Sorry!

The error message was:
Tried disconnecting and reconnecting my Twitter account, same thing happened.
yeah I tried that yesterday with twitter too and got the same thing

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 7:21 pm
by fluffy
Lunkhead wrote:I didn't put in a requirement to add songs to a playlist, oops. So they created a bunch of empty playlists. I'm going to disable the feature for now. Then when I have time I'm going to put in a two song minimum. I don't think that will stop them but it will at least create a good source of random two song playlists. :/
Oh, by the way, you might also consider using bbcode and http:// as rejection parameters for a basic spam filter, since that seems to be what they're trying to get at.

What I wonder is who the hell made a spambot that was specifically working to create accounts on SFJukebox just waiting for any sort of UGC mechanism to come about. Do you know the timing of when the accounts were created compared to when playlists were even a thing? And presumably you have IP address logs and so on.

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 8:32 pm
by Lunkhead
Twitter integration is broken because the version of the Twitter library I use was relying on some Twitter API v1 calls, which Twitter shut off a while ago. I have to upgrade to a newer version of the library to fix it, which I probably won't have time to do till the weekend.

I'm very surprised about the spam too. I think it may actually be people, not bots, acting as spambots via a mechanical Turk or something. In order to sign up and sign in, you have to be able to receive your password via email, which seems like kind of a lot to have to code up in a spam bot. But who knows?

Spammers have been making accounts and logging in for a while, I don't remember the exact time frames, but a year or more.

I'll add those filters and I'm going to add a two song minimum, but I'm not sure that will work...

Re: Song Fight! Jukebox

Posted: Wed Nov 06, 2013 8:42 pm
by fluffy
You could ask questions that require at least a passing familiarity with song fight, like "favorite fight title" or "are you fdrink"

Re: Song Fight! Jukebox

Posted: Thu Nov 07, 2013 3:13 am
by Caravan Ray
fluffy wrote:You could ask questions that require at least a passing familiarity with song fight, like "favorite fight title" or "are you fdrink"
Spambots will see through that.

You need harder questions, like:
"How many Doom Faeries does Neil Thrum have?"
"What is your favourite Rone Rivendale guitar solo?", or
"Is Billy's Little Trip a spambot?"

Re: Song Fight! Jukebox

Posted: Thu Nov 07, 2013 10:22 am
by Lunkhead
Twitter login should work again. Playlists are back with some very crude spam prevention that probably won't work.

Re: Song Fight! Jukebox

Posted: Thu Nov 07, 2013 10:48 am
by fluffy
Caravan Ray wrote:
fluffy wrote:You could ask questions that require at least a passing familiarity with song fight, like "favorite fight title" or "are you fdrink"
Spambots will see through that.

You need harder questions, like:
"How many Doom Faeries does Neil Thrum have?"
"What is your favourite Rone Rivendale guitar solo?", or
"Is Billy's Little Trip a spambot?"
The questions still need to be answered by a human, CRay.

Re: Song Fight! Jukebox

Posted: Thu Nov 07, 2013 10:55 am
by fluffy
Hey Lunkhead, it'd be cool if you could do an audio preview from the search interface on the playlist generator.